CuPy issues in `test_cosmicray`
- Dominant language
- Python
- Stars
- 93
- Forks
- 92
- Avg merge
- 14h 44m
- Merged PRs (30d)
- 30
Description
Almost all of these will ultimately fail because astroscrappy converts to numpy (or at least moves things off the GPU):
+ test_cosmicray_lacosmic_ccddata - DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implemen...
+ test_cosmicray_gain_correct[True-True] - DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implemen...
+ test_cosmicray_gain_correct[True-False] - DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implemen...
+ test_cosmicray_gain_correct[False-True] - DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implemen...
+ test_cosmicray_gain_correct[False-False] - DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implemen...
+ test_cosmicray_lacosmic_accepts_quantity_gain - DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implemen...
+ test_cosmicray_lacosmic_accepts_quantity_readnoise - DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implemen...
+ test_cosmicray_lacosmic_detects_inconsistent_units - DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implemen...
+ test_cosmicray_lacosmic_warns_on_ccd_in_electrons - DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implemen...
+ test_cosmicray_lacosmic_invar_inbkg[new_args0] - DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implemen...
+ test_cosmicray_lacosmic_invar_inbkg[new_args1] - DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implemen...
+ test_cosmicray_lacosmic_invar_inbkg[new_args2] - DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implemen...
+ test_cosmicray_median - DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implemen...
+ test_cosmicray_median_ccddata - DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implemen...
+ test_cosmicray_median_masked - DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implemen...
+ test_cosmicray_median_background_None - DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implemen...
+ test_cosmicray_median_gbox - DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implemen...
+ test_cosmicray_median_rbox - DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implemen...
+ test_background_deviation_box - TypeError: Implicit conversion to a NumPy array is not allowed. Please use `.get()` to construct a NumPy array explicitly.
+ test_background_deviation_filter - TypeError: Implicit conversion to a NumPy array is not allowed. Please use `.get()` to construct a NumPy array explicitly.
+ test_cosmicray_lacosmic_pssl_deprecation_warning - DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implemen...
+ test_cosmicray_lacosmic_pssl_does_not_fail - DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implemen...
Contributor guide
Research direction
Start by running the listed test_cosmicray and background_deviation tests with CuPy enabled, then inspect how astroscrappy receives the data and where NumPy conversion occurs. Done means the listed DeprecationWarning and TypeError failures are resolved without breaking the existing cosmic-ray and background-deviation test behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- numpy, python
- Domain
- backend, testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100