astropy / astropy/astroquery

MAINT: cleanup all `from_name` usage in tests

Open
#3,348 1 comment 2 reactions 0 assignees View on GitHub
cleanup
Dominant language
Python
Stars
791
Forks
451
Avg merge
1d 3h
Merged PRs (30d)
4

Description

We should try to limit the unnecessary use of `SkyCoord.from_name` in the tests and just use baked in numbers for coordinates instead. That would remove some unnecessary extra calls to upstream that we don't need to test for (e.g. astropy should have enough coverage to ensure `from_name` just works).

Narrative docs is different IMO as the `from_name` is a really nice end user functionality, so we can keep promoting its usage.

Contributor guide

Open the contributing guide

Research direction

Search the test suite for SkyCoord.from_name usage and identify calls that only obtain fixed coordinates for tests. Replace those test-only lookups with baked-in coordinate numbers, while leaving narrative documentation examples unchanged. Run the affected tests and confirm they no longer make unnecessary upstream coordinate-service calls.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.