astropy / astropy/astroquery

'SCRIPT_NUMBER_ID' column disappeared in Simbad.query_region() after v0.4.8 update

Open
#3,209 6 comments 0 reactions 0 assignees View on GitHub
simbad
Dominant language
Python
Stars
791
Forks
451
Avg merge
1d 3h
Merged PRs (30d)
4

Description

Hello there,
it appears that the v0.4.8 of astroquery deleted the column 'SCRIPT_NUMBER_ID' when using the function Simbad.query_region(). The column, introduced here (https://github.com/astropy/astroquery/issues/2047) was crucial to connect the unequivocally inputs and outputs of a query, by assigning each row a number corresponding to the i-th input region.

Apparently the column was renamed as 'object_number_id' in Simbad.query_objects() (https://github.com/astropy/astroquery/pull/2954). However, no such column exists for Simbad.query_region().

Would it be possible to restore this column (even with a different name)?

Thank you in advance for your the consideration. :)

Contributor guide

Open the contributing guide

Research direction

Start by comparing the outputs of Simbad.query_region() and Simbad.query_objects(), using issue #2047 and pull request #2954 as context for the identifier column. Trace how query_region() builds its result and verify that the completed change restores an identifier linking each returned row to its input region.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.