Improve `MastMissions` queries by enabling criteria decorators
- Dominant language
- Python
- Stars
- 791
- Forks
- 451
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 4
Description
The MastMissions API requires parameters to be fed as a JSON dictionary, which means the syntax restructuring that's performed by `services.py`'s `_build_catalogs_params` is not done for these queries, and therefore criteria decorators are not enabled for MastMissions the way they are for Catalogs (see documentation examples [here](https://astroquery.readthedocs.io/en/latest/mast/mast.html#mission-searches)) Recently the PANSTARRS API switched to requiring params to be passed in a JSON dictionary so I did some refactoring to allow for this while also preserving the criteria decorator capabilities (https://github.com/astropy/astroquery/pull/2727) . This can also be done with MastMissions queries.
Contributor guide
Research direction
Start in services.py at _build_catalogs_params and compare the MastMissions query path with the PANSTARRS refactoring in pull request 2727. Review the MastMissions documentation examples for mission searches. Done means MastMissions accepts JSON-dictionary parameters while criteria decorators remain available as they are for Catalogs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100