astropy / astropy/astroquery

BUG: alma PI queries are broken

Open
#2,584 11 comments 0 reactions 0 assignees View on GitHub
alma bug
Dominant language
Python
Stars
791
Forks
451
Avg merge
1d 3h
Merged PRs (30d)
4

Description

The test querying based on the PI name is broken, and I couldn't trivially figure out the column name we should use instead.

To reproduce run:

`pytest astroquery/alma/tests/test_alma_remote.py::TestAlma::test_misc --remote-data`

or the examples from the docs in the section https://astroquery.readthedocs.io/en/latest/alma/alma.html#querying-by-other-parameters.

The test send the tap query: `"select * from ivoa.obscore WHERE obs_creator_name LIKE '%Bally%' AND science_observation='T' AND data_rights='Proprietary'"`, which also results an empty table

cc @andamian @keflavich

Contributor guide

Open the contributing guide

Research direction

Run astroquery/alma/tests/test_alma_remote.py::TestAlma::test_misc with --remote-data and inspect the failing TAP query. Compare it with the examples in the Alma documentation section on querying by other parameters to determine the current field for PI-name searches. Done means the remote test and documented examples return the expected results instead of an empty table.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, sql
Domain
api, data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.