self._authenticated is inconsistent for mast
- Dominant language
- Python
- Stars
- 791
- Forks
- 451
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 4
Description
As @ceb8 pointed out in this PR review https://github.com/astropy/astroquery/pull/1874/files#r521553922, there is a bit of room for code cleanup in the mast authentication module.
E.g. I find self._authenticated a bit inconsistent, it's set to `False` only after logout, but not at init when e.g. a token is not provided.
I label this as a bug, but please let me know if you think otherwise.
cc @tomdonaldson @jaymedina
Contributor guide
Research direction
Read the MAST authentication module and compare how self._authenticated is initialized when no token is provided with how it is updated during logout. Confirm the intended unauthenticated state and add or update coverage so the flag is consistent in both paths.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100