astropy / astropy/astroquery

Add test coverage for output_file not None cases for gaia and/or utils.tap

Open
#2,328 1 comment 0 reactions 0 assignees View on GitHub
gaia testing utils.tap
Dominant language
Python
Stars
791
Forks
451
Avg merge
1d 3h
Merged PRs (30d)
4

Description

This is a follow-up for PR #2311. We went ahead to merge the changes for the release, and as the missing test coverage predates the PR they should not hold up the merge and release. See discussion: https://github.com/astropy/astroquery/pull/2311#pullrequestreview-894038779

cc @mhsarmiento

Contributor guide

Open the contributing guide

Research direction

Start by locating the existing tests and implementations for gaia and utils.tap, then review PR #2311 and its linked discussion for the intended output_file behavior. Add coverage for output_file values that are not None and run the relevant test suite; done means those cases are exercised without delaying the release changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.