MNT: all modules should do raise_for_status
- Dominant language
- Python
- Stars
- 791
- Forks
- 451
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 4
Description
This is a maintenance/improvement issue that all modules need to raise for status rather than silently accept 404/etc returns. Suitable to be tackled incrementally, and suitable for new contributors.
I paste the module list here. Many already do this, but all needs to be confirmed before checking the box for it:
- [ ] alfalfa
- [ ] alma
- [ ] astrometry_net
- [ ] atomic
- [ ] besancon
- [ ] cadc
- [ ] casda
- [ ] cds
- [ ] cosmosim
- [ ] dace
- [ ] esa/hubble
- [ ] esa/iso
- [ ] esa/xmm_newton
- [ ] esasky
- [ ] eso
- [ ] exoplanet_orbit_database
- [ ] fermi
- [ ] gaia
- [ ] gama
- [ ] gemini
- [ ] heasarc
- [ ] hips2fits
- [ ] hitran
- [ ] image_cutouts/first
- [ ] ipac/irsa
- [ ] ipac/irsa/ibe
- [ ] ipac/irsa/irsa_dust
- [ ] ipac/irsa/sha
- [ ] ipac/ned
- [ ] ipac/nexsci/nasa_exoplanet_archive
- [ ] jplspec
- [ ] lamda
- [ ] magpis
- [ ] mast
- [ ] mpc
- [ ] nasa_ads
- [ ] nasa_exoplanet_archive
- [ ] ned
- [ ] nist
- [ ] noirlab
- [ ] nrao
- [ ] nvas
- [ ] oac
- [ ] ogle
- [ ] sdss
- [ ] simbad
- [ ] skyview
- [ ] solarsystem/imcce
- [ ] solarsystem/imcce/miriade
- [ ] solarsystem/imcce/skybot
- [ ] solarsystem/jpl/horizons
- [ ] solarsystem/jpl/sbdb
- [ ] solarsystem/mpc
- [ ] splatalogue
- [ ] svo_fps
- [ ] template_module
- [ ] ukidss
- [ ] vamdc
- [ ] vizier
- [ ] vo_conesearch
- [ ] vsa
- [ ] wfau
- [ ] xmatch
Contributor guide
Research direction
Choose one unchecked module from the listed module names and inspect its request-handling entry points for existing status checks. Run that module's tests if available; done means confirming or updating the module so unsuccessful HTTP responses are not silently accepted, then checking off only that module.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, networking
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100