GaiaClass.ROW_LIMIT prevents effective searching
- Dominant language
- Python
- Stars
- 791
- Forks
- 451
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 4
Description
The GaiaClass.ROW_LIMIT put in from this PR:
https://github.com/astropy/astroquery/pull/1641
Now limits all queries to return only the top 50 objects. There is no way to adjust this row limit without breaking python conventions over class attributes.
A better solution would be to use this attribute (set to unlimited) as a default to all the search methods, with a parameter to these methods for overriding the default.
Contributor guide
Research direction
Start by reviewing GaiaClass.ROW_LIMIT and the changes in PR 1641, then trace the Gaia search methods that currently enforce the limit. The work is done when searches default to the configured unlimited value while allowing callers to override the row limit without changing class-attribute conventions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100