astropy / astropy/astroquery

JPL SBDB query fails to get proper diameter value

Open
#1,542 1 comment 0 reactions 0 assignees View on GitHub
jplsbdb
Dominant language
Python
Stars
791
Forks
451
Avg merge
1d 3h
Merged PRs (30d)
4

Description

I was testing SBDB module with some test cases. When I tested 1980 PA:
```python
from astroquery.jplsbdb import SBDB
obj = SBDB.query('1980 PA', phys=True)
print(obj['phys_par']['diameter'])
```
gives ``km`` without any value. When I searched 1980 PA on SBDB, it shows ``1.0`` (km), so I am a bit wondering that it does not understand the value ``1``.

Python 3.7 on macOS 10.14.6 with astroquery 0.3.10.dev5703.

Contributor guide

Open the contributing guide

Research direction

Start at the SBDB.query entry point using the reported 1980 PA example with phys=True, and inspect how the returned phys_par diameter is parsed. Compare the result with the SBDB value of 1.0 km; done means the query returns the numeric diameter rather than only the km unit.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.