Significant increase in import time for several sub-packages
- Dominant language
- Python
- Stars
- 5.3k
- Forks
- 2.2k
- Avg merge
- 1d 18h
- Merged PRs (30d)
- 74
Description
It looks like there has been a significant (~40%) increase in import time for several sub-packages recently:
https://www.astropy.org/astropy-benchmarks/#imports.timeraw_import_astropy_coordinates
https://www.astropy.org/astropy-benchmarks/#imports.timeraw_import_astropy_nddata
asv seems to suggest that https://github.com/astropy/astropy/pull/9365 is the cause (cc @mhvk @eteq ).
Interestingly astropy.time also saw such an increase:
https://www.astropy.org/astropy-benchmarks/#imports.timeraw_import_astropy_time
but that was then fixed in https://github.com/astropy/astropy/pull/9491.
Contributor guide
Research direction
Start with the ASV import benchmarks for astropy.coordinates, astropy.nddata, and astropy.time, then compare the suspected changes in pull requests #9365 and #9491. Determine whether the roughly 40% regression remains and identify the relevant import-time change; done means the affected benchmark imports no longer show the regression.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- performance
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100