astropy / astropy/astropy

Add property testing to convolution

Open
#9,504 0 comments 0 reactions 0 assignees View on GitHub
convolution Effort-medium Feature Request Package-expert testing
Dominant language
Python
Stars
5.3k
Forks
2.2k
Avg merge
1d 18h
Merged PRs (30d)
74

Description

We have essentially no tests of convolution with asymmetric kernels, which means that if we had confused the cross-correlation definition with the convolution definition, we wouldn't have any tests to tell us. There are some nice property tests we can add: https://en.wikipedia.org/wiki/Convolution#Algebraic_properties

Contributor guide

Open the contributing guide

Research direction

Start by locating the convolution implementation and its existing tests in the Astropy repository. Use the issue's Wikipedia link to identify relevant algebraic properties and focus on asymmetric kernels. Done means the properties are covered by tests that distinguish convolution from cross-correlation.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.