`ilshift` structured-unit should share memory
- Dominant language
- Python
- Stars
- 5.3k
- Forks
- 2.2k
- Avg merge
- 1d 18h
- Merged PRs (30d)
- 74
Description
Followup to https://github.com/astropy/astropy/pull/13638
> For a structured array, the `self.unit._to(other)` will fail; in principle, we can indeed work on the view for that case too, but it needs more work. Note that it didn't really work on the view before either: it just calculated the new value and overrode the view with that.
To do better, one would need a version of `_recursively_apply` with multiple factors. Out of scope here, I think!
_Originally posted by @mhvk in https://github.com/astropy/astropy/issues/13638#issuecomment-1245672536_
Contributor guide
Research direction
Start by reading PR 13638 and the referenced issue 13638, focusing on the existing ilshift behavior for structured arrays and structured units. The work is complete when ilshift on a structured-unit view shares memory correctly; the issue notes that this may require a version of _recursively_apply supporting multiple factors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100