astropy / astropy/astropy

Add support for coordinate frame Attribute's to not propagate when transformed

Open
#11,782 0 comments 0 reactions 0 assignees View on GitHub
coordinates
Dominant language
Python
Stars
5.3k
Forks
2.2k
Avg merge
1d 19h
Merged PRs (30d)
75

Description

#11730 fixed a bug identified in #11277 in which transformations involving `SkyOffsetFrame`'s were failing because of duplicate `origin` attributes. However, the fix really only addresses this one case, and it would be good to have a general solution to this. One idea could be to add a new boolean argument/attribute to the `Attribute` class, e.g., `propagate=True/False`, which tells the transformation machinery whether to carry along the value of this attribute or not.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing issues #11730 and #11277, then trace the coordinate transformation machinery and the Attribute class. Define which attributes should propagate during transformations and how the general behavior should cover the SkyOffsetFrame case; done should include tests for the reported failure and broader attribute handling.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.