astropy / astropy/astropy-data

Allow non-ascii characters in sites.json (when enough astropy user base supports it)

Open
#40 2 comments 0 reactions 0 assignees View on GitHub
Feature Request sites data
Dominant language
CSS
Stars
13
Forks
62
Avg merge
42m
Merged PRs (30d)
1

Description

#38 fixed an issue described in #36 where astropy doesn't correctly parse the ``sites.json`` file when it has non-ascii characters. While #38 fixes it, it does so by removing some characters that are proper names that really ought to be unicode. astropy/astropy#7082 fixes the underlying problem by making everything unicode-compliant in astropy. So this issue is about esentially reverting #38, and, more broadly, allowing UTF-8 in the ``site.json`` file.

We do *not* want to do this yet, however, as it will instantly break all released astropys (at the time of this writing). So instead, we are thinking to follow the suggestion of https://github.com/astropy/astropy-data/issues/36#issuecomment-358695793 - wait a while until we think most installed astropy have the fix (could be a long time...), and then bring in the non-ascii characters again.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.