astropy / astropy/astroplan

Implement "two-pass" version of rise/set/transit functions

Open
#440 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
225
Forks
121
Avg merge
28m
Merged PRs (30d)
1

Description

This is prompted by the discussion around these functions in #424 - specifically https://github.com/astropy/astroplan/pull/424#issuecomment-543156136 and the related thread.

@StuartLittlefair pointed out that a two-pass solution, where you can get away with a finer grid by doing it once to get a 24-hr guess, and then re-gridding around that to do a better guess. That should let the user get away with a much smaller `N` parameter (from #424), and make things quite a bit faster as a result.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the rise, set, and transit functions and read the discussion in issue #424, especially the linked pull-request comment and related thread. Determine how the proposed two-pass approach should use a coarse 24-hour estimate and re-grid around it; done means supporting a smaller N while producing a faster, more accurate result.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.