astropy / astropy/asdf-astropy

Remove `tag` validators in fits schema

Open
#240 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
19
Forks
22
Avg merge
6h 1m
Merged PRs (30d)
1

Description

The fits schema contains a `tag` validator:

https://github.com/astropy/asdf-astropy/blob/fa5f1f452412fc969b79ead4a0471d38dfa3a9cc/asdf_astropy/resources/schemas/fits/fits-1.1.0.yaml#L77

for the same `tag` in the manifest:
https://github.com/astropy/asdf-astropy/blob/fa5f1f452412fc969b79ead4a0471d38dfa3a9cc/asdf_astropy/resources/manifests/astropy-1.2.0.yaml#L16

Look to see if this does anything and if not remove it and any other redundant `tag` keywords in schemas.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with asdf_astropy/resources/schemas/fits/fits-1.1.0.yaml and asdf_astropy/resources/manifests/astropy-1.2.0.yaml at the linked tag entries, then search the other schema files for tag keywords. Determine whether each validator is redundant; done means removing only redundant validators while leaving schema behavior unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, yaml
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.