astrodbtoolkit / astrodbtoolkit/astrodb_utils

Move ingest_parallax function here from SIMPLE

Open
#55 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
0
Forks
10
PR merge metrics
No merged PRs in 30d

Description

@exu-112 has written an excellent [`ingest_parallax` function](https://github.com/SIMPLE-AstroDB/SIMPLE-db/blob/d0e29ba7789d3946009c6352e1d63c30366fd803/simple/utils/astrometry.py#L20) and [tests](https://github.com/SIMPLE-AstroDB/SIMPLE-db/blob/d0e29ba7789d3946009c6352e1d63c30366fd803/tests/test_astrometry.py#L70). The function has good error handling and deals with the adopted column. Parallax table already exists in the template so makes sense to move this function over. Probably best to go ahead and start an `astrometry.py` module.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading the referenced ingest_parallax implementation in simple/utils/astrometry.py and its tests in tests/test_astrometry.py. Create the proposed astrometry.py module in astrodb_utils and port the function and tests, including adopted-column handling and error cases. Done means the function is available here with its referenced tests passing.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.