astrodbtoolkit / astrodbtoolkit/astrodb_utils

Add units expectations to ingest functions

Open
#20 7 comments 0 reactions 0 assignees View on GitHub
dev-docs enhancement
Dominant language
Python
Stars
0
Forks
10
PR merge metrics
No merged PRs in 30d

Description

In SIMPLE, we assume units and note what the expectation is in the docs. This is *extremely* error prone. Other options
- Include units in the column name. e.g., `parallax_mas`, `parallax_error_mas`
- Include units as a column in all tables with a measurement. We could then have a test to make sure that that string corresponds to a astropy unit.

Contributor guide

No contributing guide indexed for this repository

Research direction

No files, tests, or entry points are named. Start by locating the ingest functions and reviewing how their unit assumptions are documented; compare the proposed column-name and units-column approaches. Done requires a decided convention, updated unit expectations, and a way to verify measurement units against astropy units.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.