astrodbtoolkit / astrodbtoolkit/astrodb-bot

db.save_database() requires a positional directory argument not shown in the ingest skill templates

Open
#100 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1
Forks
4
Avg merge
2d 10h
Merged PRs (30d)
5

Description

**Where:** `astrodb-ingest-publications` skill's `references/ingest_publication_api.md`, "Saving" section, and `scripts/ingest_publication.py` template — both call `db.save_database()` with no arguments.

**What happened:** Running the generated script with `SAVE_DB = True` raised `TypeError: Database.save_database() missing 1 required positional argument: 'directory'`. The installed `astrodbkit` version requires `save_database(directory, clear_first=True, reference_directory="reference", source_directory="source")`.

**Workaround:** Called `db.save_database("data/")` (matching `database.toml`'s `data_path`) in both ingest scripts.

**Suggested change:** Update `references/ingest_publication_api.md` and `scripts/ingest_publication.py` (and any other ingest skill's template making the same call — `astrodb-ingest-sources`, `astrodb-ingest-photometry` should be checked too) to show `db.save_database("data/")` or explicitly note the `directory` argument is required and should match `database.toml`'s `data_path`.

---
_Reported from a gotchas.md log filed by a skill user (2026-08-28)._

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with references/ingest_publication_api.md and scripts/ingest_publication.py, checking the Saving section and the call used when SAVE_DB is true. Then inspect the astrodb-ingest-sources and astrodb-ingest-photometry templates for the same call. Done means the templates pass the data directory matching database.toml’s data_path or explicitly document that required argument.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
documentation, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
82/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.