astro / astro/node-oembed

Query string params don't persist

Open
#11 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
38
Forks
15
PR merge metrics
No merged PRs in 30d

Description

If the url is https://youtu.be/0JUN9aDxVmI?t=32s, the response from node-oembed is
```
{"width":612,"author_url":"https://www.youtube.com/user/Harvard","title":"Advanced Algorithms (COMPSCI 224), Lecture 1","html":"","thumbnail_width":480,"version":"1.0","type":"video","thumbnail_url":"https://i.ytimg.com/vi/0JUN9aDxVmI/hqdefault.jpg","thumbnail_height":360,"height":344,"provider_name":"YouTube","author_name":"Harvard University","provider_url":"https://www.youtube.com/","original_url":"https://youtu.be/0JUN9aDxVmI?t=32s"}
```

But directly from youtube (https://www.youtube.com/oembed?url=https%3A%2F%2Fyoutu.be%2F0JUN9aDxVmI%3Ft%3D32s), it's
```
{"thumbnail_url":"https:\/\/i.ytimg.com\/vi\/0JUN9aDxVmI\/hqdefault.jpg","provider_url":"https:\/\/www.youtube.com\/","thumbnail_height":360,"type":"video","version":"1.0","author_url":"https:\/\/www.youtube.com\/user\/Harvard","author_name":"Harvard University","thumbnail_width":480,"width":480,"title":"Advanced Algorithms (COMPSCI 224), Lecture 1","provider_name":"YouTube","height":270,"html":"\u003ciframe width=\"480\" height=\"270\" src=\"https:\/\/www.youtube.com\/embed\/0JUN9aDxVmI?start=32\u0026feature=oembed\" frameborder=\"0\" allowfullscreen\u003e\u003c\/iframe\u003e"}
```

Note you the iframe does not handle the 32s from node-oembed, but does from youtube.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.