astral-sh / astral-sh/ty

Rename `invalid-method-override` rule

Open
#2,001 0 comments 0 reactions 0 assignees View on GitHub
diagnostics overrides
Dominant language
Python
Stars
19.7k
Forks
331
Avg merge
23h 12m
Merged PRs (30d)
44

Description

We have lots of rules that complain about invalid method overrides of one sort or another, and we'll be adding more in the future. The `invalid-method-override` rule is specifically about Liskov violations, but its name doesn't reflect that currently. `unsound-method-override` might be better, though it's still not great. Maybe `incompatible-method-override`?

Contributor guide

Open the contributing guide

Research direction

No files, tests, or entry points are named. First locate the implementation and references for the `invalid-method-override` rule, then review the proposed names and project conventions. Done means agreeing on a replacement that reflects Liskov violations and consistently renaming the rule.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, rust
Domain
devtools
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.