astral-sh / astral-sh/ruff

N813 seems too broad in scope

Open
#9,237 2 comments 0 reactions 0 assignees View on GitHub
needs-decision rule
Dominant language
Rust
Stars
49.6k
Forks
2.4k
Avg merge
1d 21h
Merged PRs (30d)
435

Description

Hi, currently N813 is raised even for cases such as
``` python
import netCDF4 as nc
```
which seem innocuous from the point of view of the rule: https://docs.astral.sh/ruff/rules/camelcase-imported-as-lowercase/

Would it make sense to restrict the applicability of this rule to cases where `name.to_lowercase() == asname.to_lowercase()`? I would be happy to send a PR if that was the case!

Contributor guide

Open the contributing guide

Research direction

Start with the N813 implementation and reproduce the reported `import netCDF4 as nc` example against the rule described in the linked documentation. Confirm the intended cases still produce diagnostics while this innocuous import does not; add or update coverage for both outcomes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.