astral-sh / astral-sh/ruff

Allow for deselection of all fixable errors when `check`ing

Open
#3,939 4 comments 2 reactions 0 assignees View on GitHub
cli
Dominant language
Rust
Stars
49.6k
Forks
2.4k
Avg merge
2d 1h
Merged PRs (30d)
458

Description

:wave:

Over in https://www.pantsbuild.org/ we're adding `ruff` support. Only one nit so far. We separate running tools that fix code from ones that only lint. Since `ruff` does both, the user will see `fix`able ruff errors when `lint`ing AND they'll see our "ruff made changes when trying to fix".

So ideally, in `lint` mode, we turn off the fixable errors. Not a dealbreaker, just a confusing message to our users.

Contributor guide

Open the contributing guide

Research direction

The issue concerns Ruff's check/lint modes and the selection of fixable errors, but it names no files, tests, or entry points. Start by locating the command handling for check and the existing fixable-diagnostic filtering behavior, then identify the relevant tests. Done means lint mode can deselect all fixable errors without affecting non-fixable diagnostics or fix mode.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, rust
Domain
cli, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.