astral-sh / astral-sh/python-build-standalone

Double-check target_cflags in cpython-unix/targets.yml

Open
#680 0 comments 0 reactions 1 assignee Claimed by @geofft View on GitHub
Dominant language
Python
Stars
4.4k
Forks
314
Avg merge
1d 9h
Merged PRs (30d)
27

Description

Our native builds all have
```yaml
- '-fvisibility=hidden'
# Needed to prevent BOLT from crashing.
- '-fdebug-default-version=4'
```

The cross builds don't have `-fvisibility=hidden` and I sort of suspect it's not needed - 924693c91331426d9909649e6bb5cdcae8446784 does stuff in `build-cpython.sh` to handle symbol visibility differently, which applies to all our builds.

We also upgraded BOLT recently and we should double-check what's going on with that second flag.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.