asteroid-team / asteroid-team/asteroid
(Wavesplit) Comments on the implementation
- Dominant language
- Python
- Stars
- 2.6k
- Forks
- 450
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/mpariente/asteroid/blob/aa3485bc57ef1f21d37cff43fce69cc3c9c94b1c/egs/wham/WaveSplit/wavesplit.py#L143
Wavesplit uses standard convolutions, not separable (separable worked worse).
https://github.com/mpariente/asteroid/blob/aa3485bc57ef1f21d37cff43fce69cc3c9c94b1c/egs/wham/WaveSplit/wavesplit.py#L166
Before the residual stacks there is a single convolution layer with kernel size 4, 512 filters, no dilation, no stride.
Contributor guide
Research direction
Read egs/wham/WaveSplit/wavesplit.py at the linked lines 143 and 166, then compare the current implementation with the convolution details stated in the issue. The issue does not define a concrete change or acceptance criteria, so what counts as done remains unresolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, pytorch
- Domain
- audio-video-rtc, machine-learning
- Issue type
- Documentation
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100