asteroid-team / asteroid-team/asteroid

Unfolding sometimes results into concatenated channels

Open
#627 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
2.6k
Forks
450
PR merge metrics
No merged PRs in 30d

Description

https://github.com/asteroid-team/asteroid/blob/c72227e5e31f6c13ba9c9da1d0d380cc75b91fbd/asteroid/dsp/overlap_add.py#L92

![image](https://user-images.githubusercontent.com/18393505/176603617-16cb0b9f-2e49-479a-829a-6c7602c06928.png)
/We can see how torch 1.10.2 does concatenates the windows of all channels after unfold./

The expected behavior, in the code, would be to handle `(batch, chans, win_size)` per chunk
$\rightarrow$ `(batch, chans, win_size, n_chunks)`.

Thus it has to be reshaped before handling to the NN, from my perspective.
`unfolded = unfolded.reshape(batch, channels, self.window_size, -1)`

Contributor guide

Open the contributing guide

Research direction

Start in asteroid/dsp/overlap_add.py at line 92 and inspect the shape produced by unfold for multiple channels. Confirm that each chunk preserves the channel dimension and that the downstream neural network receives the expected (batch, chans, win_size, n_chunks) shape.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, pytorch
Domain
machine-learning
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.