asteroid-team / asteroid-team/asteroid

fix_length_mode="trim" can lead to confusing loss/metrics

Open
#402 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
2.6k
Forks
450
PR merge metrics
No merged PRs in 30d

Description

When using `fix_length_mode="trim"` in DCUNet, the signal is right-trimmed to the next possible size, and then zero-padded on the right to reconstruct the original size. When using a loss or metric that does not know about the actual input size to the model, the loss/metric values can be way off, since essentially a chunk of the expected signal is zeroed in the estimate. (I don't think it hurts training though.)

What to do? Maybe just add note to the docs?

Contributor guide

Open the contributing guide

Research direction

The issue names DCUNet and fix_length_mode="trim" but no files or tests. Start by locating the DCUNet documentation and the trim behavior, then verify how losses and metrics receive the zero-padded estimate; done should be a clear documentation note explaining the input-size caveat and its effect on evaluation.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, pytorch
Domain
audio-video-rtc, machine-learning
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.