assertj / assertj/assertj-generator

...internal.Iterables is used in Asserts generated by assertj-assertions-generator (java9)

Open
#197 7 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
72
Forks
47
Avg merge
1d 16h
Merged PRs (30d)
2

Description

#### Summary
Hi,
I am migrating from java 8 to 17 and had big trouble getting the generated assertions to work (actually is does not work at all, is it dead?)

But even with great hacks I cannot get arround that the generated code imports the internal class `org.assertj.core.internal.Iterables` which is (of course) not exported by assertj-core. Could this become public? Or could the code-generator be updated? Which btw has medium CVEs in it's dependencies.

#### Example

```java
import org.assertj.core.internal.Iterables;
//this is part of the generated code
public YAssert hasXs(X... xs) {
// check that actual Y we want to make assertions on is not null.
isNotNull();

// check that given X varargs is not null.
if (x== null) failWithMessage("Expecting x parameter not to be null.");

// check with standard error message, to set another message call: info.overridingErrorMessage("my error message");
Iterables.instance().assertContains(info, actual.getX(), xs);

// return the current assertion for method chaining
return this;
}
```

Package 'org.assertj.core.internal' is declared in module 'org.assertj.core', which does not export it to module 'my.assertions'

In other words: Is does not compile in Java > 8 which renders the complete code generation useless.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.