assemblee-virtuelle / assemblee-virtuelle/semapps

Utiliser le ControlledContainerMixin pour le WebIdService

Open
#981 3 comments 0 reactions 0 assignees View on GitHub
refactoring
Dominant language
TypeScript
Stars
103
Forks
14
Avg merge
1m
Merged PRs (30d)
2

Description

**Problématique**
Le WebIdService est un mélange de code obsolète ou inutile qui n'a pas été revu depuis des lustres.
Sur certaines choses comme l'envoi d'événements, il y a de la confusion avec l'AuthService.

**Proposition**
On pourrait utiliser le ControlledContainerMixin pour plus facilement gérer les side-effects propres au webId.
Voir par exemple ce service créé pour les CDLT: https://github.com/chemins-de-la-transition/semapps/blob/next/middleware/services/users.service.js
On pourrait aussi supprimer l'event `webid.created` et plutôt utiliser `auth.registered`.

**Composants concernés**
WebIdService

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading the WebIdService and comparing it with middleware/services/users.service.js, especially how ControlledContainerMixin manages side effects. Trace the webid.created and auth.registered events and resolve which event should remain. Done means the WebIdService no longer contains the obsolete or duplicated behavior and its event handling is covered by the project’s relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
authentication, backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.