assemblee-virtuelle / assemblee-virtuelle/semapps

Removing ACL Permission from resource fails using authProvider

Open
#1,296 1 comment 1 reaction 1 assignee Claimed by @srosset81 View on GitHub
bug
Dominant language
TypeScript
Stars
103
Forks
14
Avg merge
1m
Merged PRs (30d)
2

Description

When I want to remove public read ACL permissions from a resource using the semapps authProvider (`removePermission('foaf:Agent', 'acl:agentClass', 'acl:Read');`, this fails for me.

The client performs a `PUT` request on the acl resource which results in an empty ACL resource (at least after filtering in the backend).

The frontend place:
https://github.com/assemblee-virtuelle/semapps/blob/38395487a4c78d72f24784d5eb183db1535ceb49/src/frontend/packages/auth-provider/src/authProvider.js#L353-L370

Here, all default records are filtered and the result is then replaced with the `PUT`. Is that intended? When I don't filter them, I get this error: `The rights cannot be changed because they are incorrect` (triggered in `webacl.resource.setRights`).

In the backend, it fails here:
https://github.com/assemblee-virtuelle/semapps/blob/d1620eb1e384d0151ba641078b670d650ba47f1c/src/middleware/packages/webacl/services/resource/actions/setRights.js#L21

I suppose, `setRights` should check for something like a `rightsToRemove` as well?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.