assemblee-virtuelle / assemblee-virtuelle/semapps

Refactor matchActivity to always return the dereferenced activity

Open
#1,231 2 comments 0 reactions 0 assignees View on GitHub
refactoring
Dominant language
TypeScript
Stars
103
Forks
14
Avg merge
1m
Merged PRs (30d)
2

Description

Instead of returning the dereferenced activity or `false`, return an array with the success status (`true` or `false`) first, and the dereferenced activity next.

This will allow to optimise requests so that, even if the match fais, we don't need to lose dereferenced data.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating matchActivity and its callers in the TypeScript codebase, then inspect any tests covering its current return value. Done means the function always returns an array with the success status first and the dereferenced activity second, including when matching fails, with callers and tests aligned to that shape.

Written by the indexing model from the issue text.

Assessment

Tech stack
nodejs, typescript
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.