aspect-build / aspect-build/rules_ts

[Bug]: allowJs handling inconsistent across outDir|rootDir|transpiler|sourceMap options

Open
#881 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Starlark
Stars
138
Forks
87
Avg merge
2d 8h
Merged PRs (30d)
3

Description

Today some [special handling](https://github.com/aspect-build/rules_ts/blob/bbad484af105ebbdb1809c1004156bff3da7f832/ts/private/ts_project.bzl#L214-L228) exists for files that are not renamed during transpilation, however this only covers some scenarios while others remain broken.

See https://github.com/aspect-build/rules_ts/pull/880 for tests showing what's broken

Contributor guide

Open the contributing guide

Research direction

Start with the special handling in ts/private/ts_project.bzl around lines 214-228, then inspect the tests in pull request #880 to reproduce the broken allowJs combinations. The fix is complete when allowJs behaves consistently across outDir, rootDir, transpiler, and sourceMap options and the referenced tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.