aspect-build / aspect-build/rules_ts

[Bug]: `transitive_typecheck` doesn't work across NPM package boundaries

Open
#871 4 comments 0 reactions 1 assignee Claimed by @jbedard View on GitHub
bug
Dominant language
Starlark
Stars
138
Forks
87
Avg merge
2d 8h
Merged PRs (30d)
3

Description

### What happened?

I'm in the process of migrating to `--isolatedDeclarations` and `isolated_typecheck = True`.

I naively assumed that building the `transitive_typecheck` target would trigger type checking across all transitive `ts_project()` dependencies. At the moment it doesn't seem to work across NPM package / `js_library()` boundaries.

### Version

Development (host) and target OS/architectures:

Output of `bazel --version`: `bazel 8.5.0`

Version of the Aspect rules, or other relevant rules from your
`WORKSPACE` or `MODULE.bazel` file:

```
bazel_dep(name = "aspect_rules_js", version = "2.8.1")
bazel_dep(name = "aspect_rules_ts", version = "3.7.1")
```

Language(s) and/or frameworks involved: TypeScript

### How to reproduce

- Clone https://github.com/walkerburgin/transitive-typecheck-repro
- Run `bazel build //packages/foo-app:foo-app_transitive_typecheck` and observe that the build does not fail, even though there's a type error in `//packages/foo-lib`

### Any other information?

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.