aspect-build / aspect-build/rules_ts

[Bug]: `ts_config()` deps trigger type checking

Open
#739 8 comments 0 reactions 0 assignees View on GitHub
bug need: investigation
Dominant language
Starlark
Stars
138
Forks
87
Avg merge
2d 8h
Merged PRs (30d)
3

Description

### What happened?

I noticed that adding an in-repo dependency to `ts_config()` triggers type checking to run pre-maturely in dependencies as part of the `TsValidateOptions` action. Are types/transitive types actually necessary for validation?

More details and a repro [here](https://github.com/walkerburgin/tsconfig-package).

### Version

Development (host) and target OS/architectures:

Output of `bazel --version`: `aspect pro 5.11.0-alpha2.dev.41.gd94c177`

Version of the Aspect rules, or other relevant rules from your
`WORKSPACE` or `MODULE.bazel` file:

```
bazel_dep(name = "aspect_bazel_lib", version = "2.9.4")
bazel_dep(name = "rules_multitool", version = "1.0.0")
bazel_dep(name = "aspect_rules_js", version = "2.1.1")
bazel_dep(name = "aspect_rules_ts", version = "3.3.1")
bazel_dep(name = "aspect_rules_swc", version = "2.0.1")
```

Language(s) and/or frameworks involved: TypeScript

### How to reproduce

```shell
See https://github.com/walkerburgin/tsconfig-package
```

### Any other information?

_No response_

Contributor guide

Open the contributing guide

Research direction

Start with the TsValidateOptions action and the linked tsconfig-package reproduction; trace how in-repo dependencies passed to ts_config() cause type checking to run. Determine whether types or transitive types are required for validation, then verify the corrected behavior against the reproduction.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.