aspect-build / aspect-build/rules_ts

[FR]: ts_proto_library should use an aspect and run over transitive proto deps

Open
#628 0 comments 0 reactions 1 assignee Claimed by @alexeagle View on GitHub
enhancement need: discussion
Dominant language
Starlark
Stars
138
Forks
87
Avg merge
2d 8h
Merged PRs (30d)
3

Description

### What is the current behavior?

Currently, ts_proto_library produces files for the direct proto dep it is passed. This is unideal since it forces users to both vendor in all transitive proto libraries they need typescript support for, and also manually link together a tree of ts_proto_library and js_libraries which mirrors the exact structure of the proto dependencies themselves

### Describe the feature

Ideally, ts_proto_library would run an aspect over all transitive dependencies such that only one `ts_proto_library` target needs to be authored by the user. The `write_source_files` implementation would likely need to be rethought out for third party proto dependencies at that point

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.