aspect-build / aspect-build/rules_ts
[Bug]: Wrong placement of output files for ts_proto_library
- Dominant language
- Starlark
- Stars
- 138
- Forks
- 87
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 3
Description
### What happened?
`ts_proto_library` should write its output on the directory the rule was defined.
Release 4.5.0 however writes the output instead on the directory where the proto file is.
### Version
Development (host) and target OS/architectures: macos
Output of `bazel --version`: aspect 5.7.2
Version of the Aspect rules, or other relevant rules from your
`WORKSPACE` or `MODULE.bazel` file: 4.5.0
Language(s) and/or frameworks involved: rules_ts
### How to reproduce
Create a ts_proto_library where the proto file is on a different directory + BUILD.
See sample [commit](https://github.com/aspect-build/rules_ts/commit/625990fb85164fc623ede643203eda6309f38d4e) from [sample branch](https://github.com/jvliwanag/rules_ts/tree/proto-ts-path-issue).
### Any other information?
_No response_
Contributor guide
Research direction
Start with the sample commit 625990fb85164fc623ede643203eda6309f38d4e and its proto-ts-path-issue branch, then inspect the ts_proto_library rule and the BUILD setup where the proto and rule use different directories. Reproduce the issue with Bazel and confirm that generated output is placed beside the rule definition rather than beside the proto file.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100