aspect-build / aspect-build/rules_ts
[FR]: Nit, possible for tsconfigs to support the json5 extension?
- Dominant language
- Starlark
- Stars
- 138
- Forks
- 87
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 3
Description
### What is the current behavior?
A set up like this yields the error below
```
ts_config(
name = "project_root_base_tsconfig",
src = "tsconfig.allRootPaths.json5", # This is the problem line here
)
ts_project(
name = "all_ts",
srcs = [
":stuff",
],
extends = ":project_root_base_tsconfig",
)
```
> ERROR: /workspace/typescript/BUILD.bazel:175:11: in extends attribute of validate_options rule //typescript:_validate_all_ts_options: '//typescript:project_root_base_tsconfig' does not produce any validate_options extends files (expected .json). Since this rule was created by the macro 'ts_project', the error might have been caused by the macro implementation
Confirmed that this is an aspect-only restrict because `yarn tsc -b typescript/tsconfig.json` works well
### Describe the feature
Possible to accept .json5 extensions too?
Contributor guide
Assessment
This issue has not been assessed yet.