aspect-build / aspect-build/rules_rollup

[FR]: Support `directory_path` for bundling

Open
#111 1 comment 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
Starlark
Stars
5
Forks
11
PR merge metrics
No merged PRs in 30d

Description

### What is the current behavior?

Currently entry-points need to be actual sources that can be referenced via labels. This is fine, but doesn't work when trying to e.g. bundle a file that originates from an npm dependency e.g. `//:node_modules/bla --> dist/index.mjs`.

### Describe the feature

`rules_js` generally makes use of `directory_path`, so it would be a canonical solution to respect those "labels" as well when bundling via Rollup.

Contributor guide

Open the contributing guide

Research direction

The issue names rules_rollup, rules_js, Rollup, and directory_path but no files or tests. Start by tracing how bundling handles entry-point labels, then compare that behavior with the directory_path labels used by rules_js. Done means an npm dependency label such as //:node_modules/bla can be bundled to dist/index.mjs.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, rollup
Domain
build-system
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.