aspect-build / aspect-build/rules_lint

[Bug]: Value bazel vocab doesn't work

Open
#778 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Starlark
Stars
154
Forks
125
Avg merge
3d 21h
Merged PRs (30d)
20

Description

### What happened?

Aspect lint vale_library Bazel fails to download and content is wrong.

```
copy_to_directory(
name = "vale_styles",
srcs = [
"@vale_Bazel//:Bazel",
"@vale_Google//:Google",
"@vale_write-good//:write-good",
],
include_external_repositories = ["*vale_*"],
)

native_binary(
name = "vale",
src = select(
{
"@bazel_tools//src/conditions:linux_x86_64": "@vale_Linux_64-bit//:vale",
"@bazel_tools//src/conditions:linux_aarch64": "@vale_Linux_arm64//:vale",
"@bazel_tools//src/conditions:darwin_x86_64": "@vale_macOS_64-bit//:vale",
"@bazel_tools//src/conditions:darwin_arm64": "@vale_macOS_arm64//:vale",
"@bazel_tools//src/conditions:windows_x64": "@vale_Windows_64-bit//:vale.exe",
},
),
out = "vale",
)

```

Error:
```
Error in download_and_extract: java.io.IOException: Error downloading [https://github.com/alexeagle/vale-bazel-vocab/archive/refs/heads/v0.1.0.zip] to /external/aspect_rules_lint++tools2+vale_Bazel/temp2709060176322150079/v0.1.0.zip: GET returned 404 Not Found
ERROR: no such package '@@aspect_rules_lint++tools2+vale_Bazel//': java.io.IOException: Error downloading [https://github.com/alexeagle/vale-bazel-vocab/archive/refs/heads/v0.1.0.zip] to /external/aspect_rules_lint++tools2+vale_Bazel/temp2709060176322150079/v0.1.0.zip: GET returned 404 Not Found
```

Patching is not enough as the content of the repo is wrong.
```
@@ -9,9 +9,9 @@
"name": "Bazel",
"description": "Dictionary of common build system and developer infra terms",
"homepage": "https://github.com/alexeagle/vale-bazel-vocab",
- "integrity": "sha256-XIuKXX0iKarKz7JIdt0v4aDVI3mlG8fKxZ7lAdMf1a0=",
- "version": "v0.1.0",
- "url": "https://github.com/alexeagle/vale-bazel-vocab/archive/refs/heads/{}.zip",
+ "integrity": "sha256-eIe+cHMVYWDnQ0LM4YBGuJJtXl2NJJcSglJqcSFTgdk=",
+ "version": "v0.1.2",
+ "url": "https://github.com/alexeagle/vale-bazel-vocab/archive/refs/tags/{}.zip",
},
{
"name": "Google",
```

Error:
```
ERROR: : Copying files to directory tools/lint/vale_styles failed: missing input file '@@aspect_rules_lint++tools2+vale_Bazel//:Bazel'
ERROR: : Copying files to directory tools/lint/vale_styles failed: 1 input file(s) do not exist
```

### Version

Development (host) and target OS/architectures:

Output of `bazel --version`:

Version of the Aspect rules, or other relevant rules from your
`WORKSPACE` or `MODULE.bazel` file:

Language(s) and/or frameworks involved:

### How to reproduce

```shell

```

### Any other information?

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by locating the Vale vocabulary declarations that produce tools/lint/vale_styles, then inspect the relevant WORKSPACE or MODULE.bazel configuration. Reproduce the Bazel download and copy failures from the issue; done means the Bazel vocabulary downloads successfully and the expected Bazel vocabulary files are present in vale_styles.

Written by the indexing model from the issue text.

Assessment

Domain
build-system, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.