aspect-build / aspect-build/rules_lint
[Bug]: ESLint v10 not supported - Cannot resolve `chalk`
- Dominant language
- Starlark
- Stars
- 154
- Forks
- 125
- Avg merge
- 3d 21h
- Merged PRs (30d)
- 20
Description
### What happened?
`@aspect_rules_lint` uses `chalk` (dependency from ESLint) in `lint/js/eslint.stylish-formatter.js`.
The dependency was dropped in ESLint v10 with eslint/eslint#20227, which causes linting to fail (with no output) and a dependent action to produce a non-fatal warning.
```
INFO: From Linting //build_defs/rollup_bundle:lib with ESLint:
There was a problem loading formatter: /home/vscode/.cache/bazel/_bazel_vscode/43824749bfca2150cc88a279b49058b6/sandbox/processwrapper-sandbox/2061/execroot/_main/bazel-out/k8-opt-exec/bin/external/aspect_rules_lint+/lint/js/eslint.stylish-formatter.js
Error: Cannot find module 'chalk'
Require stack:
- /home/vscode/.cache/bazel/_bazel_vscode/43824749bfca2150cc88a279b49058b6/sandbox/processwrapper-sandbox/2061/execroot/_main/bazel-out/k8-opt-exec/bin/external/aspect_rules_lint+/lint/js/eslint.stylish-formatter.js
FAIL: //build_defs/rollup_bundle:eslint (Exit 1) (see /home/vscode/.cache/bazel/_bazel_vscode/43824749bfca2150cc88a279b49058b6/execroot/_main/bazel-out/k8-fastbuild/testlogs/build_defs/rollup_bundle/eslint/test.log)
```
### Version
Development (host) and target OS/architectures: Linux (WSL2+Docker+devcontainer)
Output of `bazel --version`: `bazel 9.0.0`
Version of the Aspect rules, or other relevant rules from your
`WORKSPACE` or `MODULE.bazel` file:
Language(s) and/or frameworks involved: TypeScript and ESLint v10
### How to reproduce
Checkout https://github.com/Silic0nS0ldier/vscode-git-monolithic-extension/tree/661281fbbc4c6722070160592ff0249f17c1ca63 and run;
```sh
bazel test //build_defs/rollup_bundle:eslint
```
### Any other information?
_No response_
Contributor guide
Research direction
Start with lint/js/eslint.stylish-formatter.js and reproduce the failure using bazel test //build_defs/rollup_bundle:eslint against the linked revision. Trace how the formatter’s dependencies are provided under ESLint v10, then verify that the command completes successfully and produces lint output without the missing-module error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100