aspect-build / aspect-build/rules_lint

[FR]: Support clippy from rules_rust

Open
#385 6 comments 0 reactions 1 assignee Assigned to @blorente View on GitHub
enhancement
Dominant language
Starlark
Stars
154
Forks
125
Avg merge
3d 21h
Merged PRs (30d)
20

Description

### What is the current behavior?

Currently linting for rust is not supported by rules_lint. Rules_rust can run clippy, the rust linter, but it follows different idioms than rules_lint.

### Describe the feature

Utilize the existing aspect from rules_rust to enable running clippy with rules_lint

To run clippy the rules_rust way you would augment your `.bazelrc` file with
```
# https://bazelbuild.github.io/rules_rust/rust_clippy.html
build --aspects=@rules_rust//rust:defs.bzl%rust_clippy_aspect
build --output_groups=+clippy_checks
build --@rules_rust//:clippy.toml=//:clippy.toml
```

We want to create a rules_lint shapped aspect that can be configured by
```
load("@aspect_rules_lint//lint:clippy.bzl", "lint_clippy_aspect")
eslint = lint_eslint_aspect(
configs = "//:clippy.toml",
)
```

In so doing, we can enable rules_lint users to run clippy without augmenting their `.bazelrc` and leave requesting the `clippy_checks` output group to the aspect CLI or other mechanism to run rules_lint

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.