aspect-build / aspect-build/rules_lint

[Bug]: format_test eager-fetches irrelevant language tooling

Open
#329 1 comment 0 reactions 0 assignees View on GitHub
bug help wanted
Dominant language
Starlark
Stars
154
Forks
125
Avg merge
3d 21h
Merged PRs (30d)
20

Description

### What happened?

Implied here: https://github.com/bazel-contrib/bazelrc-parser-go/blob/main/format.bzl#L11-L13

> rules_lint by default creates targets for each of these languages (except starlark, which we need to add because it doesn't have a default tool label), which then no-op (but require fetching toolchains and building potentially large runfiles trees).
> Ideally it would do this filtering itself in its format_test macro

### Version

all versions

### How to reproduce

_No response_

### Any other information?

_No response_

Contributor guide

Open the contributing guide

Research direction

Start with format.bzl lines 11-13 and trace the format_test macro and its language-tool target setup. Confirm which irrelevant language tools are currently fetched or built, then verify that format_test filters them while still handling the required Starlark tool label.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.