aspect-build / aspect-build/rules_js
Support pnpm shared-workspace-lockfile=false mode
- Dominant language
- Starlark
- Stars
- 378
- Forks
- 183
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 32
Description
Tested this in https://github.com/aspect-build/rules_js/pull/367 and it is almost supported with existing constructs except that transitive deps of first-party workspace links are not picked up because the information is split across lock files.
Should be relatively easy to create an npm_translate_locks repository rule or macro to make this easy for the end user. Just have to figure out how to pass transitive deps for 1st party workspace links around when the data is split across lock files.
cc @alexeagle @jondlm @sushain97
Contributor guide
Research direction
Start by reviewing the behavior tested in pull request 367 and the existing npm_translate_locks repository rule or macro. Trace how transitive dependencies of first-party workspace links are represented when information is split across lock files; the work is done when pnpm shared-workspace-lockfile=false includes those dependencies.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100