aspect-build / aspect-build/rules_js

Angular architect test rule escaping its runfiles but not the sandbox

Open
#347 2 comments 0 reactions 0 assignees View on GitHub
bug need: investigation
Dominant language
Starlark
Stars
378
Forks
183
Avg merge
1d 9h
Merged PRs (30d)
32

Description

This is causing test failures if srcs are not copied to bin

As seen here https://github.com/aspect-build/bazel-examples/blob/a76be559cd89a645308ff0f2e6a02a82c780010f/angular/defs.bzl#L133 and here https://github.com/aspect-build/bazel-examples/blob/a76be559cd89a645308ff0f2e6a02a82c780010f/angular/defs.bzl#L195

Contributor guide

Open the contributing guide

Research direction

Start by inspecting angular/defs.bzl at the linked lines 133 and 195, then reproduce the test failure when srcs are not copied to bin. Compare how the Angular architect test rule escapes runfiles with its behavior in the sandbox; done means the affected tests no longer fail in that configuration.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.