aspect-build / aspect-build/rules_js

[FR]: Support for specific versions with allowBuilds and onlyBuiltDependencies

Open
#2,803 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Starlark
Stars
378
Forks
183
Avg merge
1d 9h
Merged PRs (30d)
32

Description

### What is the current behavior?

As of pnpm 10.19, you can specify versions on dependencies in `onlyBuiltDependencies`: https://pnpm.io/blog/releases/10.19#versions-in-onlybuiltdependencies But as far as I can tell, we are not set up to handle this yet.

### Describe the feature

It would be good to add support for this for both `onlyBuiltDependencies` and [allowBuilds](https://pnpm.io/settings#allowbuilds) so that we can handle this situation correctly.

Contributor guide

Open the contributing guide

Research direction

Start by reading the pnpm 10.19 release note on versions in onlyBuiltDependencies and the allowBuilds settings documentation linked in the issue. Trace how rules_js currently interprets both dependency lists, then identify the relevant tests or entry points for their existing behavior. Done means version-specific entries work correctly in both settings.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.