aspect-build / aspect-build/rules_js

[FR]: Support for configDependencies in pnpm-workspace.yaml

Open
#2,801 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Starlark
Stars
378
Forks
183
Avg merge
1d 9h
Merged PRs (30d)
32

Description

### What is the current behavior?

There is a kind of dependency which we do not support yet called [configDependencies](https://pnpm.io/config-dependencies). As far as I can tell, we currently ignore it.

### Describe the feature

This came up during testing of pnpm 11, because the presence of `configDependencies` is one thing that can cause `pnpm-lock.yaml` to be a multi-document file. We are likely going to get pnpm 11 working by just ignoring the extra document, but it seems worth considering whether we should eventually add real support for this.

Contributor guide

Open the contributing guide

Research direction

The issue names pnpm-workspace.yaml and pnpm-lock.yaml but no implementation files or tests. Start by locating the existing workspace and lockfile parsing entry points and compare their handling with pnpm's configDependencies format. Before coding, establish whether support means parsing the extra lockfile document or only avoiding breakage; done should be a defined behavior covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
yaml
Domain
build-system
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.