aspect-build / aspect-build/rules_js

[Bug]: js_run_binary does not allow depset srcs

Open
#1,844 1 comment 0 reactions 0 assignees View on GitHub
bug can close? need: repro
Dominant language
Starlark
Stars
378
Forks
183
Avg merge
1d 9h
Merged PRs (30d)
32

Description

### What happened?

```
File "/Users/mhill/bazel/3c3e59429c86c7585f0ffa57350a75ac/external/aspect_rules_js/js/private/js_run_binary.bzl", line 378, column 21, in js_run_binary
srcs = srcs + extra_srcs,
Error: unsupported binary operation: depset + list
```

### Version

Development (host) and target OS/architectures:

Output of `bazel --version`:
7.1
Version of the Aspect rules, or other relevant rules from your
`WORKSPACE` or `MODULE.bazel` file:

Language(s) and/or frameworks involved:

### How to reproduce

_No response_

### Any other information?

_No response_

Contributor guide

Open the contributing guide

Research direction

Start in js/private/js_run_binary.bzl at line 378 and inspect how js_run_binary combines srcs with extra_srcs. Reproduce the reported Bazel 7.1 error if possible, then verify that depset srcs are accepted without breaking existing list inputs. Done means the unsupported depset-plus-list error is covered by a regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.