aspect-build / aspect-build/rules_js

Documentation `data` of `npm_translate_lock` outdated?

Open
#1,639 1 comment 0 reactions 0 assignees View on GitHub
documentation
Dominant language
Starlark
Stars
378
Forks
183
Avg merge
1d 9h
Merged PRs (30d)
32

Description

> package_json Deprecated.
> Add all package.json files that are part of the workspace to data instead.

This parameter needs to be updated it seems:

> data Data files required by this repository rule when auto-updating the pnpm lock file.
> Only needed when update_pnpm_lock is True. Read more: [using update_pnpm_lock](https://github.com/aspect-build/rules_js/blob/main/docs/pnpm.md#update_pnpm_lock)

Contributor guide

Open the contributing guide

Research direction

Start with the linked docs/pnpm.md section on update_pnpm_lock and compare its description of npm_translate_lock's data parameter with the current issue text. Update the documentation so the parameter guidance matches current behavior, then check the surrounding pnpm documentation for consistent wording.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system, documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.