aspect-build / aspect-build/rules_js

[Bug]: pkg is a directory; dependency checking of directories is unsound

Open
#1,408 22 comments 4 reactions 0 assignees View on GitHub
documentation help wanted
Dominant language
Starlark
Stars
378
Forks
183
Avg merge
1d 9h
Merged PRs (30d)
32

Description

### What happened?

I have a dependencies on `prettier@2.8.8` and after updating to the latest `1.34.1` and Bazel 7.0.0 I get the following error
```
WARNING: /home/user/code/BUILD.bazel:42:22 //:.aspects_rules_js/node_modules/prettier@2.2.8/pkg is a director; dependency checking of directories is unsound
```

### Version

Development (host) and target OS/architectures:

Output of `bazel --version`: 7.0.0

### How to reproduce

```shell
I'm not able to provide too much detail on my workspace but suspect anything which depends at least on `prettier==2.8.8` would repro this problem.
```

### Any other information?

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the warning with prettier@2.8.8, rules_js 1.34.1, and Bazel 7.0.0, using the reported .aspects_rules_js/node_modules/prettier@2.2.8/pkg path as the starting point. Investigate why dependency checking treats this directory as an unsound dependency; done means the reproduction no longer emits the warning and directory dependencies are checked correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.